allow for provider declaration with index to be parsed. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lines <[email protected]>
|
Is it worth opening a PR against the upstream project instead of, or in addition to, this fork? They do say "We would be happy to review PRs to fix bugs in existing functionality," which IMO this is. |
Since the upstream project owner is Hashicorp, and this suggested change is to add support for OpenTofu (a direct open source competitor to their Terraform product), I do not believe it is worth attempting to submit this change there as I am quite certain it will never get approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am aware of the statement that this repository does not accept external pull requests, but this addresses an issue with terraform-docs that cannot otherwise be resolved (as far as I can tell), so I am going to try just incase.
With the recent added support to
.tofufiles, it appears there is at least a limited desire to support OpenTofu. This update allows for a provider declaration on a resource or data source with an index to be specified, as was introduced with OpenTofu v1.9.0. This fixes issue 839 opened on terraform-docs, and is the only way to do so as far as I can tell.Please let me know if any additional activities are required on my part to make this acceptable.